From c1d0fc9d87f548b89cf1a34500f30f88cc20924c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20L=C3=B8vbr=C3=B8tte=20Olsen?=
 <dan06082@skole.vtfk.no>
Date: Wed, 25 Nov 2020 09:09:08 +0100
Subject: [PATCH] move pointer walking to front of loop lol

---
 Commissions/flis/IMT/Case3/case3.c | 73 ++++++++++++++++++------------
 1 file changed, 44 insertions(+), 29 deletions(-)

diff --git a/Commissions/flis/IMT/Case3/case3.c b/Commissions/flis/IMT/Case3/case3.c
index bc5f736..91c94b1 100644
--- a/Commissions/flis/IMT/Case3/case3.c
+++ b/Commissions/flis/IMT/Case3/case3.c
@@ -21,6 +21,18 @@ struct Node* newNode(void) {
     return nNode;
 }
 
+void free_all(struct Node* node) {
+    if (!node) {
+        return;
+    };
+
+    for (int i = 0; i < 10; i++) {
+        free_all(node);
+    };
+
+    free(node);
+}
+
 int numbers[] = {113, 11354, 77777, 255044};
 
 int main(void) {
@@ -31,50 +43,53 @@ int main(void) {
     
     for (int i = 0; i < n_numbers; i++) {       // Go through all the phone numbers in the global list
         struct Node* pointer = root;            // Create a pointer that points to whatever part of the trie we're working on
-        char number[9];                         // A number has 8 + \0 chars
+        char number[8 + 1];                         // A number has 8 + \0 chars
         snprintf(number, 9, "%i", numbers[i]);  // Convert int to string
         int len_number = strlen(number);
-        for (int j = 0; j < len_number - 1; j++) {  // loop over chars in the phone number
+        for (int j = 0; j < len_number; j++) {  // loop over chars in the phone number
+            int index = number[j] - '0';            // Go to the node we're testing
+            if (pointer->children[index == NULL]) {
+                pointer->children[index] = newNode();
+            };
+            pointer = pointer->children[index];
+
             if (j == len_number - 1) {          // if we are at the last iteration
                 if (pointer->isEnd == true) {   // Check if we've seen the number before
                     printf("Duplicate Number found at element %i, number %s", i, number);
                     break;
-                }
-                else {                          // if we're at the last iteration, and isEnd isnt true, its either a new number OR we found a prefix
-                    bool continues = false;
-                    for (int k = 0; k < 10; k++) {
-                        if( pointer->children[k] != NULL) {
-                            continues = true;
-                        };
-                    };
-                    if (continues == true) {
-                        printf("FOUND PREFIX IN NUMBER\n");
-                        printf("%s and %s", number, number);
-                        while (pointer->isEnd != true) { // follow the first paths you can find
-                            for (int k = 0; k < 10; k++) {
-                                if( pointer->children[k] != NULL) {
-                                    pointer = pointer->children[k];
-                                    printf("%c", k + '0');
-                                    break;
-                                };
-                            };
-                        };
-                        printf("\n");
-                        return 0;
+                };
+                // if we're at the last iteration, and isEnd isnt true, its either a new number OR we found a prefix
+                bool continues = false;
+                for (int k = 0; k < 10; k++) {
+                    if( pointer->children[k] != NULL) {
+                        continues = true;
                     };
                 };
+                if (continues == true) {
+                    printf("FOUND PREFIX IN NUMBER\n");
+                    printf("%s and %s", number, number);
+                    while (pointer->isEnd != true) { // follow the first path you can find
+                        for (int k = 0; k < 10; k++) {
+                            if( pointer->children[k] != NULL) {
+                                pointer = pointer->children[k];
+                                printf("%c", k + '0'); // Print the path as we go
+                                break;
+                            };
+                        };
+                    };
+                    printf("\n");
+                    free_all(root); // Clean up
+                    return 0; // return true or success or whatever
+                };
                 pointer->isEnd = true;
-            }
+            };
             else if (pointer->isEnd == true) {  // if we've already seen a shorter number with this prefix
-                printf("Found prefix!");
+                printf("Found prefix!\n");
                 for (int k = 0; k < j; k++) {
                     printf("%c", number[k]);
                 }
                 printf("\n");
             };
-            int index = number[j+1] - '0';
-            pointer->children[index] = newNode();
-            pointer = pointer->children[index];
         };
     };
 }
\ No newline at end of file